Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui-editor): enable component poc and feedback form #14210

Merged
merged 23 commits into from
Dec 6, 2024
Merged

feat(ui-editor): enable component poc and feedback form #14210

merged 23 commits into from
Dec 6, 2024

Conversation

nkylstad
Copy link
Member

Description

Implement switch for enabling new add-component view, with feedback form.
To be used for testing new design concept for ux-editor, specifically for adding components.

Screen.Recording.2024-11-28.at.17.59.29.mov

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Nov 28, 2024
@nkylstad nkylstad changed the title Feat(UI editor)/enable component poc and feedback form Feat(ui-editor)/enable component poc and feedback form Nov 28, 2024
@nkylstad nkylstad changed the title Feat(ui-editor)/enable component poc and feedback form feat(ui-editor): enable component poc and feedback form Nov 28, 2024
wrt95
wrt95 requested changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@wrt95 wrt95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments added😊

@codecov Codecov
Copy link

codecov bot commented Nov 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 95.50%. Comparing base (8e95988) to head (410dbc7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...iners/DesignView/AddItem/ToggleAddComponentPoc.tsx 64.28% 4 Missing and 1 partial ⚠️
...src/containers/DesignView/AddItem/FeedbackForm.tsx 86.66% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #14210      +/-   ##
==========================================
- Coverage   95.53%   95.50%   -0.03%     
==========================================
  Files        1814     1817       +3     
  Lines       23615    23652      +37     
  Branches     2732     2735       +3     
==========================================
+ Hits        22560    22590      +30     
- Misses        802      808       +6     
- Partials      253      254       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nkylstad
Copy link
Member Author

I have updated the paragraph components ++ to use size="sm". It occurs to me that if that is the standard that we expect to use across our solution, we should just implement it as the default in the Studio-components 🤔 So that we don't have to add it manually each time.

@nkylstad nkylstad requested a review from wrt95 November 28, 2024 20:04
@github-actions github-actions bot added the area/overview Area: Related to the overview page label Nov 29, 2024
wrt95
wrt95 approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@wrt95 wrt95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🥳

@Ildest Ildest self-requested a review November 29, 2024 13:10
Ildest
Ildest approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@Ildest Ildest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noen småjusteringer, men du bestemmer @nkylstad

@nkylstad nkylstad merged commit 3ab9086 into main Dec 6, 2024
8 of 10 checks passed
@nkylstad nkylstad deleted the feat(ui-editor)/enable-component-poc-and-feedback-form branch December 6, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ildest Ildest Ildest approved these changes

@wrt95 wrt95 wrt95 approved these changes

Assignees
No one assigned
Labels
area/overview Area: Related to the overview page area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkylstad @wrt95 @Ildest